Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated text.css #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

PasunuriSrinidhi
Copy link

Using rem units for font sizes instead of px

Using rem units for font sizes instead of px
@loganloganlogan
Copy link
Contributor

Hi @PasunuriSrinidhi, I collaborate with @bproffitt (ASF VP Marketing & Publicity) and we're working on several major updates to the ASF website to improve the user experience -- coming in May. What you suggested is a great idea for accessibility. We will include this commit as part of that update. We want to test it first in relation to other updates being made to ensure it will work as intended. If you have any questions, let us know.

@PasunuriSrinidhi
Copy link
Author

Thanks for your response @loganloganlogan , I don't have any questions. I would also like to contribute to improve the user experience and am very much excited to help you with the ASF website.
Thank you

@hen
Copy link
Member

hen commented Jul 19, 2023

@loganloganlogan following up here given the 'coming in May' comment. Anything to update?

@bproffitt
Copy link
Contributor

Thank you for all of the changes you have been pushing through @hen , but can you make sure I have reviewed things first? That's my function as VP M&P with the ASF

@loganloganlogan
Copy link
Contributor

Hi @PasunuriSrinidhi, please submit a PR to the preview/paulau branch for review by the ASF M&P VP (@bproffitt).

@sebbASF
Copy link
Contributor

sebbASF commented Jul 31, 2023

@loganloganlogan - the preview/paulau branch is no longer up to date with respect to default branch which is currently in use: are you sure the PR should be applied to that branch?

@loganloganlogan
Copy link
Contributor

Yes, they should be applied to that branch as it will be updated before being merged.

@thejon07
Copy link

thejon07 commented Feb 1, 2024

Thanks for your response @loganloganlogan , I don't have any questions. I would also like to contribute to improve the user experience and am very much excited to help you with the ASF website. Thank you

hi are you a frontend developer?

@raboof
Copy link
Member

raboof commented Aug 29, 2024

Yes, they should be applied to that branch as it will be updated before being merged.

is this still the current stats of things? that branch is now "19 commits ahead of, 48 commits behind"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants